-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Io: Account for free space on the host device #13560
Conversation
eabbc93
to
e3a201f
Compare
Oh,thanks. But this will potentially break #12761 again. |
How long does it need to be static? If we keep the free space constant from game start, but don't maintain it between save states, would that probably work? Free space should take into account sector size, ideally. The byte sum of files definitely isn't what free space is reduced by on a real PSP - it uses FAT, so files are allocated in chunks of sectors. -[Unknown] |
If don't maintain it between save states, I think it might not work between save states. But I think it's hard to avoid this, because even if we use simulated freespace, we can't guarantee that users won't change the content of savedata between save states. Keeping the free space constant from game start and do maintain it between save states might work, but I worry that still report that disc is free even if the disc is full. |
I wonder if it's better to have a game id check then, as much as I hate them... I think it's important to report low free space when we can. Maybe it'd be good to check how this game responds to the memory stick events of removal and reinsertion. Maybe we could act like the card was reinserted when a major space change occurs. But I think some PSP games just kicked you out if you did that, or didn't let you save again... -[Unknown] |
Fixing game bugs/misbehaviors like this is definitely fair game for compat.ini checks... |
I'm fine with a compat.ini check, maybe this case is uncommon(I hope so, I don't hope we have to maintain a long list for this). |
This seems to be necessary for Assassin's Creed. See hrydgard#12761.
I don't think I have this game, but does that work? Not really tested. -[Unknown] |
Tested simply on Android, works. |
See #13520. If there's less free space on the actual device, return that instead of simulated free space based on usage. This will tell games about the space problems properly.
Also changed the comment slightly - I'm pretty sure they released 2 GB memory sticks before that Harry Potter game was released. I don't think it was an imagination problem, just a testing problem.
-[Unknown]