Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with GE dumps #11171

Merged
merged 4 commits into from
Jun 14, 2018
Merged

Fix some issues with GE dumps #11171

merged 4 commits into from
Jun 14, 2018

Conversation

unknownbrackets
Copy link
Collaborator

This fixes a few issues with dumps and the GE debugger:

  1. Dumps still had the old texture addresses, which added extra flushing and "Step Tex" had a bunch of wrong textures.
  2. Dumps set a stall before every prim, so you never saw prims combine.
  3. Sometimes on GL, you'd get a crash when stepping because a texture would get built outside a render pass.
  4. When exiting PPSSPP during GE stepping, things hung (mistake in Improve debugger threadsafety and consistency #10987 due to threading.)

With this it's more realistic to see the performance and flushing behavior of GE dumps. I made the changes in execution to avoid breaking compatibility with old dumps.

-[Unknown]

@unknownbrackets
GE Debugger: Prevent hang on shutdown.
0ed2c03 
Since we're blocking the Emu thread, we can't use a hook from the Emu
thread to wake up.

The change to lifecycle callbacks caused this.
@unknownbrackets
GE Debugger: Fix asserts when reading debug tex.
ccef997 
This is unfortunate, but right now BuildTexture() applies the sampling
settings which happen within a render pass.  So we must have a render
pass.
@unknownbrackets
GE Debugger: Use a class for dump execution.
f7443aa
@unknownbrackets
GE Debugger: Stall less liberally on GE dump exec.
582bc2d 
This makes it easier to compare performance and flushing bugs.
@unknownbrackets unknownbrackets added this to the v1.7.0 milestone Jun 11, 2018
@hrydgard hrydgard merged commit e03aeba into hrydgard:master Jun 14, 2018
@unknownbrackets unknownbrackets deleted the debugger branch June 14, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@unknownbrackets @hrydgard