Improve debugger threadsafety and consistency #10987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
unknownbrackets
force-pushed
the
debugger-core
branch
from
dedceca to
738c1ec
Compare
unknownbrackets
force-pushed
the
debugger-core
branch
from
27652b6 to
4df7395
Compare
Otherwise we lose wakeups and hang.
This allows us to poll coreState and know if a new stepping needs to be sent. This is useful to allow e.g. regs to show changes per step.
Otherwise things can get freed while we're trying to inspect them.
It was crashing when accessing from another thread. If in the future we go down to only the remote debugger, we could potentially remove this.
unknownbrackets
force-pushed
the
debugger-core
branch
from
4df7395 to
6fbd0e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minor changes to the main core system that allow multiple connections (e.g. from #10909 and Windows debugger, or even multiple WebSockets) to work correctly, as well as a little cleanup.
The shutdown functions are changed to starting/started to enable some locks, but those aren't used yet. I'm including it here so we can merge this separately and have a build in case there are issues with the other places it impacts.
This should only minorly impact the current Windows debugger, right now.
Note: more changes will come when introducing stepping for Android/etc., but that's for later.
-[Unknown]