Display: Avoid limiting FPS without a clear #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of a dirty heuristic to avoid the slowdown in hrydgard#8538.
hrydgard
added a commit
that referenced
this pull request
Feb 6, 2019
It's a pretty gnarly hack-upon-a-hack. Better to remove the original hack (limit fps) in the general case.
hrydgard
added a commit
that referenced
this pull request
Feb 6, 2019
It's a pretty gnarly hack-upon-a-hack. Better to remove the original hack (limit fps) in the general case.
hrydgard
added a commit
that referenced
this pull request
Feb 6, 2019
It's a pretty gnarly hack-upon-a-hack. Better to remove the original hack (limit fps) in the general case.
hrydgard
added a commit
that referenced
this pull request
Feb 6, 2019
It's a pretty gnarly hack-upon-a-hack. Better to remove the original hack (limit fps) in the general case.
hrydgard
added a commit
that referenced
this pull request
Feb 6, 2019
It's a pretty gnarly hack-upon-a-hack. Better to remove the original hack (limit fps) in the general case.
hrydgard
added a commit
that referenced
this pull request
Feb 6, 2019
It's a pretty gnarly hack-upon-a-hack. Better to remove the original hack (limit fps) in the general case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a dirty heuristic to avoid the slowdown in #8538. On desktop, this seems to fix the slowdown everywhere but OpenGL (which is still really slow - but for other reasons.)
Slightly ugly, but there's a sense to it - the other case (FF4) that triggered this problem also doesn't seem to have clears for the frames that are accidentally too frequent.
The number of games that don't clear for real scenes are pretty low, so I think this is relatively safe. God of War definitely does clear.
-[Unknown]