Persona 2 Innocent Sin's UI lines don't work at all resolutions

[internetakias]

When BR's off the stripes that make up the backgrounds of certain UI elements are being spaced out correctly.

When any form of BR is turned on however, the spacing gets messed up, causing certain stripes to be spaced further away from each other.

[bonquacks]

I noticed it too, but it seems like such a minor issue, considering that it does not affect the playability of the game one way or the other, as compared to the massive transparency issue it had previously which was resolved thanks to @hrydgard

Thanks for the report anyway, this one will take time to fix.

[internetakias]

Huh. Seems like on Android it's the complete opposite
BR off:

Br on:

[dbz400]

I think it may be related to scissor . I may be wrong . Is this tested with latest build ?

[internetakias]

Yes, both my PC and Galaxy S3 are using the latest build

[dbz400]

Can you a bit older version of it ? v0.9.1-15-g1ea0cd0 (which is before the scissor fix)

[internetakias]

Not really seeing a difference
PC:
BR OFF

BR ON

ANDROID:
BR OFF

BR ON

[dbz400]

It is funny .They are exactly reversed among Android and PC version . Really not much idea what is real cause .....

[internetakias]

Should I try attaching a framedump? Would it help any?

[dbz400]

Btw , we can see the rendering of 'Normal' is also different even stripes are correct .

[internetakias]

Here are the frame dumps
ON: https://docs.google.com/file/d/0BzC2uL8lp2t-V0doa3Z4c0l3b0E/edit?usp=sharing
OFF: https://docs.google.com/file/d/0BzC2uL8lp2t-NDZuUTgzRko1TlE/edit?usp=sharing

[dbz400]

That would be helpful .Will check it out.

[dbz400]

That would be helpful .Will check it out.

[dbz400]

Alright .Just able to test it .Looks like bit different indeed.

• Real PSP
  
  
• PPSSPP
  
  

[dbz400]

@internetakias , just wonder which version you are able to reproduce the difference between rendering mode ? as i cannot reproduce it .

[internetakias]

v0.9.1-131-g2d89323 64 BIT

[internetakias]

Just tested it out on the 32 bit build, and couldn't notice anything different.

[unknownbrackets]

Adventures To Go! (which is nowhere as good as a Persona game) also has the "too dark" issue.

-[Unknown]

[dbz400]

Humm i just tried v0.9.1-131-g2d89323 64 bit , also cannot see the difference .Strange.

[internetakias]

Hmm... Maybe it has to do with the graphics card? I have an AMD Radeon HD 6770. Also, all modes of buffered rendering produce the same result, FYI.

[dbz400]

However , can 131 build still able to produce the following correct one from your system ?

[unknownbrackets]

The lines seem okay on desktop, at least for me, but it's solid if render resolution is set to 2x.

How does this look for you now?

Software rendering looks pretty good now and is not too dark (with #5158.)

Dark issue is already covered by #3379.

-[Unknown]

[internetakias]

It looks fine on PC, haven't checked on my GS3 yet, though.

[unknownbrackets]

For me, this makes it look much more correct on all resolutions:

void FramebufferManager::SetLineWidth() {
#ifndef USING_GLES2
    glEnable(GL_LINE_SMOOTH);
    if (g_Config.iInternalResolution == 0) {
        glLineWidth(std::max(1.0f, (float)(PSP_CoreParameter().renderWidth / 480.0f)) + 0.5f);
        glPointSize(std::max(1.0f, (float)(PSP_CoreParameter().renderWidth / 480.0f)));
    } else {
        glLineWidth((float)g_Config.iInternalResolution + 0.5f);
        glPointSize((float)g_Config.iInternalResolution);
    }
#endif
}

Lines are pretty uncommon. I wonder if we should/can redo them as polygons to try to get the width more correct...

-[Unknown]

[hrydgard]

We can, of course, the same way we deal with rectangles: Software transform them to screen space, then tesselate (make triangles) manually. I don't think it's very well defined what to do at corners of line strips though, the PSP doesn't care about the corner style because there are no more-than-one-pixel-wide lines on it.

[internetakias]

Just a heads up, it seems like this issue is present in the D3D9 backend now

[trostboot]

This is still present and behaves differently depending on the backend and rendering resolution. Win10, 64bit, v1.2.1-56-gcc4e7c4. AMD R9 270X, 16.2.1 driver.

OGL, 1xIR:

OGL, 2xIR:

D3D, 1xIR:

D3D, 2xIR:

Basically, it seems to be fine at 2x (and other multiples of 2) in OGL, and at 1x in D3D.

[Panderner]

Same happens in Eternal Punishment:

[hrydgard]

Yeah, this is an oldie but goodie. Will be fixed if we ever implement #8276 ...

[unknownbrackets]

I haven't tested this, but #15076 may help.

-[Unknown]

[ghost]

Here's the results I don't get the real issue here though 😅

ppsspp v1.12.3-136

Vulkan

PSP

[hrydgard]

Nice, looks pretty good!

Maybe not perfect, but not sure it's possible to get it perfect with the information we have from the game (just plain line draw commands).

[unknownbrackets]

I think that part always kinda looked that way (see even first screenshots), it was actually the cross-hatch shaded backgrounds this bug was about.

I'm going to reopen though, the lines need some work at some resolutions.

-[Unknown]

[hrydgard]

Ah I see, oh yeah, the hatched backgrounds are way better indeed.

[unknownbrackets]

Just to clarify status after that last change, here's a frame dump: #3332_ULUS10584_persona2_lines.zip

Correct (PSP):

Software rendering:

GLES/Vulkan (they're pretty much the same):

As noted in #15091, the diagonal lines are still too think.

-[Unknown]