-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected performance drop [Corpse Party] #15348
Comments
Hm, those peaks look quite nasty indeed.. |
Do the same peaks, just with a presumably lower amplitude, occur on PC? I want to make sure this isn't IO related - I know Android recently made IO much slower. It's interesting that LockLwMutex is so hot, it's probably some sort of tight loop, I guess. I don't think that has timings yet. -[Unknown] |
This better matches tests on real firmware. These funcs are sometimes often used. See hrydgard#15348 - Corpse Party.
@unknownbrackets The desktop computer handles it better, but I think the peaks are relatively the same. |
@Nabokov86 Does it work better in the latest builds (829, for example?) |
@hrydgard Oh, no! It definitely got better! |
Still not great, but looks better indeed! Do you still get audio glitches? I wonder if this happens to any degree on the real PSP, or if there are more related timing issues somehow. |
@hrydgard Audio glitches are still present, but they are shorter and much less annoying. Still sometimes the sound is noticeably interrupted, especially in certain areas. |
Do the debug statistics show anything different now? -[Unknown] |
@unknownbrackets No :( |
Strange. I'd be less surprised if sceAtracDecodeData was maybe the cuplrit, but I wonder why it's locking mutexes enough that it's noticeably slow... I wonder if unlock is just behind it in slowness...? When #15368 is merged, it may be easier to catch these blips using frame advance, and especially see if there's interesting stats right before or right after. I'm also interested in whether the time taken is significantly different when frame advancing. -[Unknown] |
@unknownbrackets I apologize for the late response. #15368 is merged, right? |
You can map a button in control mapping to frame advance. Then when you press that button, it will pause, and you can keep pressing it to step forward one frame at a time. To stop frame advance, press whatever button is mapped to fast-forward. -[Unknown] |
@unknownbrackets Thanks for the quick reply! Checked twice, I definitely don't have that button. Could this option be unavailable on android? |
@unknownbrackets Yes, frame advance is not available on android. I recorded two videos: using frame advance and 5% speed. The result is quite different. 5% speed: Frame advance: Hope this will be useful. |
Android: Android_debug.mp4 |
Has anything improved in the very latest git builds? We made another change, which might help. -[Unknown] |
@unknownbrackets No, nothing. |
There was another recent change, has this improved on Android? -[Unknown] |
@unknownbrackets Same, nothing has changed :( Peaks on the graph look the same. A very short image lag is noticeable during peaks as before. ULJM05704_00059 |
I discovered a new thing. Bluetooth-friendly buffer reduces audio glitches a lot in this game. |
Yeah well that means that we still have stalls, just that the buffer is large enough with that setting to cover for it.. |
I have been thinking of putting atrac decode on a thread, which might help this. I suspect the game is decoding the entire background music for the next area during the scene transition. -[Unknown] |
I don't think so. The background music does not change during scene transitions. For example, there is a dead end in this scene. The background music does not change, there seems to be no new sounds at all. The only new content is textures and a text note. The textures are loaded before this peak on the graph. Every time you enter this location causes this. Looks like something is loaded/decoded every time for this particular scene. |
@EternalsDarkhole No, it didn't help. |
Can you upload save state of this area/stage of this game where it lag. |
@EternalsDarkhole Sure.
It lags almost everywhere more or less, though. |
Thanks! |
Yeah, I think so. But I have the Japanese version ULJM-05704 |
I cannot reproduce this kind of issue on the usa version of this game on my phone using ppsspp latest build. Screenrecorder-2022-04-13-20-50-46-65.mp4 |
Maybe this issue is similar to KoF Orochi Collection #12543 where the USA version is smooth while the JAP version is slow. |
Game or games this happens in
ULJM05704 - コープスパーティー ブラッドカバー リピーティッドフィアー
What area of the game
The game runs very fast, but sometimes there is a big drop in performance. Especially when you go from one location to another.
This causes the sound to stutter for a moment, which is annoying.
Speed seen in PPSSPP
With unlimited speed - 800%, when dropped - 30-60%.
GE frame capture and debug statistics
Platform
Android
Mobile phone model or graphics card
Mali-G31 GPU
PPSSPP version affected
v1.12.3-776-g1c18c172a
V1.12.3
V1.11.3
V1.10.3
Last working version
No response
Graphics backend (3D API)
OpenGL / GLES
Vulkan
Any other notes or things you've tried
I tried resetting the settings, tried other android devices, same issue.
Checklist
The text was updated successfully, but these errors were encountered: