Phantasy Star Portable 2 Floor Clipping

[Peduls]

What happens?

The floor textures flicker/become invisible when nearing the edge of the screen.

What should happen?

The floor should appear solid near the edge of the screen. I first noticed the issue in v1.7 and is not present in v1.6.3 I'm trying to narrow down which version it is first observed in.

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Operating System
Windows 10 Enterprise 2016 LTSB 64-bit
CPU
Intel Core i7 4790K @ 4.00GHz
Haswell 22nm Technology
RAM
16.0GB Dual-Channel DDR3 @ 799MHz (11-11-11-28)
Motherboard
ASUSTeK COMPUTER INC. Z97-A (SOCKET 1150)
Graphics
Acer S231HL (1920x1080@60Hz)
R240HY (1920x1080@60Hz)
4095MB NVIDIA GeForce GTX 1070 (EVGA)
Storage
465GB Samsung SSD 850 EVO 500GB (SSD)
2794GB TOSHIBA HDWD130 (SATA)
Optical Drives
ASUS DRW-24B1ST j
Audio
High Definition Audio Device

[hrydgard]

This would likely be another case of the remaining clipping problem with vertex range culling... We've seen a couple of those (but can't find the latest issue about it, @unknownbrackets can you?)

[Leopard20]

Um, this? #11551

[unknownbrackets]

It could also be the depth hacks this game has, though. I think they are not even needed using "accurate depth".

Is this new?

-[Unknown]

[Abbanon]

@Peduls Is this issue fixed in 1.7.1 build 204-gd08a2eed6?

EDIT: Nevermind. Testing myself, the issue still exists after the culling change build.

FURTHER EDIT: Proven to not be due to the viewport/depth hack implemented specifically for the game.
Possibly a culling issue similar to reports like #11593 (now fixed) and #11601 (same issue as here)

GE Dump:
ULUS10529_0001.zip

Screenshot for reference:

[Peduls]

Yeah, the problem not only still exists, but is now making an appearance in other games as well such as Monster Hunter Portable 3rd HD.

[unknownbrackets]

Just to clear things up: this is related to "range culling" and #11551. It has nothing to do with #11593, and definitely wouldn't have been fixed by #11594. Those last two are related to "cull mode flipping", which is unrelated (even though both have "cull" in their name.)

I'm not sure it's useful to have this open separately from #11551. #11601 may be a different story, though.

-[Unknown]

[Peduls]

The latest developmental build (v1.7.1-219-gd1cf34cdf) fixed the issue in MHP3rdHD but nothing changed for PSP2 so it seems they're unrelated unfortunately.

[Saramagrean]

Maybe, same problem in MGS:PW? I should seperate issue?

GE dump from Android use latest git build (1.7.1-219)
ULUS10509.ppdmp.zip

[Peduls]

Looks fine to me. Probably a different issue that is android specific.

[hrydgard]

Any change in the latest builds here or is it still bad?

[Abbanon]

The issue still exists in v1.7.5-431-g9736bc431
(as of the moment of this post, newer builds haven't been released for Windows because the Windows builder seems to be bugged - Orphis has been notified by Unknown)
Here's a supplementary GE dump and screenshot:
ULUS10529_0001.zip

[hrydgard]

Ah. It's possible that v1.7.5-442 might have fixed or improved it.

[hrydgard]

450 is up now, please try that.

[Abbanon]

Trying with 452-gdaba63b00 and the issue still persists.
ULUS10529_0001.zip

[hrydgard]

Ok, thanks.

[hrydgard]

I'm not closing this because I'm not yet positive about the relationship between the depth range hack and vertex range culling, but pushing it to 1.9.0. This is "fixed" for 1.8.0 through the above workaround.

[Peduls]

Not sure if this is related or not. Could be a different issue but there's this strange triangular artifacting around the edges of certain textures/polygons.

[hrydgard]

That's some type of Z fighting (two polygons very close in Z (depth) so they keep hitting almost the same depth values, sometimes one wins, sometimes the other). In this game we enforce a lower depth resolution than PPSSPP would normally use to solve some text issues, not sure if that is contributing here.

[unknownbrackets]

I think the floor panels here may have been the guardband issue (#12058, #14168, etc.) and I am not reproducing it anymore.

As with the others, this is likely not resolved on Mali yet.

Also, I think we use a depth range hack for Phantasy Star, really think we could remove that now...

-[Unknown]

[ghost]

How about this now after #16504

[hrydgard]

Most or all of these clipping issues should be solved now. Please re-open if it isn't, closing.