Remove unused includes to improve portability
#2
Conversation
The presence of those `include`s limits the platform support of this library. Specifically, cross-compiling to `wasm32-unknown-unknown` is not possible. These are only used in commented code, it seems, so this compiles without further changes. I've confirmed this by compiling against the Rust Tier 1 targets[^1] except for the following: - `i686-pc-windows-msvc`: I'm on Linux and don't know how to cross- compile for that. - `i686-unknown-linux-gnu`: The required GCC version is not packaged for my distribution, and I failed to install it via other means. Some of those builds I've done locally, other indirectly, by building a version of Fornjot that includes this commit on GitHub Actions: - https://github.com/hannobraun/Fornjot/actions/runs/3249616834/jobs/5332219174 - https://github.com/hannobraun/Fornjot/actions/runs/3249616834/jobs/5332219243 - https://github.com/hannobraun/Fornjot/actions/runs/3249616834/jobs/5332219325 In addition, I compiled locally for the following targets, all of which worked without problems: - wasm32-unknown-unknown - wasm32-wasi [^1]: https://doc.rust-lang.org/rustc/platform-support.html#tier-1-with-host-tools
The upstream version can't be compiled to `wasm32-unknown-unknown`. My fork includes the following pull requests: - hporro/robust-predicates#1 - hporro/robust-predicates#2
|
I should be able to test in the platforms you haven't. I'll do it in the following days! |
|
Thank you, sounds great! |
|
Actually, I misunderstood and it's quite difficult to test those configurations for me too (and I don't quite have a lot of time). Still, I'll merge this. |
|
I also published a new version of the crate, if you want to use it with these changes :) |
Thank you, @hporro! For what it's worth, I think it's quite unlikely that there are any build problems with the configuration we weren't able to test.
Nice! I'll upgrade today 😄 |
The presence of those
includes limits the platform support of this library. Specifically, cross-compiling towasm32-unknown-unknownis not possible.These are only used in commented code, it seems, so this compiles without further changes. I've confirmed this by compiling against the Rust Tier 1 targets1 except for the following:
i686-pc-windows-msvc: I'm on Linux and don't know how to cross- compile for that.i686-unknown-linux-gnu: The required GCC version is not packaged for my distribution, and I failed to install it via other means.Some of those builds I've done locally, other indirectly, by building a version of Fornjot that includes this commit on GitHub Actions:
In addition, I compiled locally for the following targets, all of which worked without problems:
Footnotes
https://doc.rust-lang.org/rustc/platform-support.html#tier-1-with-host-tools ↩