Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylintfix: depedencies break in new pylint and pyflakes #86

Merged
merged 5 commits into from
May 23, 2018
Merged

Pylintfix: depedencies break in new pylint and pyflakes #86

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
396e679
depedencies break in new pylint and pyflakes
JensTimmerman May 23, 2018
2fe5904
Merge branch 'pylintfix' of github.com:JensTimmerman/vsc-install into…
JensTimmerman May 23, 2018
bd9e323
Merge branch 'master' into pylintfix
itkovian May 23, 2018
4bcaf58
version bump
JensTimmerman May 23, 2018
c46e727
Merge branch 'pylintfix' of github.com:JensTimmerman/vsc-install into…
JensTimmerman May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/vsc/install/shared_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def _log(self, level, msg, args):

RELOAD_VSC_MODS = False

VERSION = '0.11.00'
VERSION = '0.11.1'

log.info('This is (based on) vsc.install.shared_setup %s' % VERSION)

Expand Down Expand Up @@ -1381,7 +1381,7 @@ def parse_target(self, target, urltemplate=None):
else:
log.info('adding prospector to tests_require')
tests_requires = new_target.setdefault('tests_require', [])
tests_requires.extend(['prospector >= 0.12.1', 'pylint-django == 0.9.1'])
tests_requires.extend(['prospector >= 0.12.1', 'pylint<2.0.0', 'pyflakes<1.7.0,>=1.5.0'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JensTimmerman OK to drop the requirement on specific version of pylint-django?

Also: missing version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this workaround is no longer needed since it was fixed, see prospector-dev/prospector#245

new_target['tests_require'] = tests_requires

if self.private_repo:
Expand Down