Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylintfix: depedencies break in new pylint and pyflakes #86

Merged
merged 5 commits into from
May 23, 2018

Conversation

JensTimmerman
Copy link
Contributor

fix pylint and pyflakes to older version

@@ -1381,7 +1381,7 @@ def parse_target(self, target, urltemplate=None):
else:
log.info('adding prospector to tests_require')
tests_requires = new_target.setdefault('tests_require', [])
tests_requires.extend(['prospector >= 0.12.1', 'pylint-django == 0.9.1'])
tests_requires.extend(['prospector >= 0.12.1', 'pylint<2.0.0', 'pyflakes<1.7.0,>=1.5.0'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JensTimmerman OK to drop the requirement on specific version of pylint-django?

Also: missing version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this workaround is no longer needed since it was fixed, see prospector-dev/prospector#245

@itkovian
Copy link
Member

Version bump?

@itkovian itkovian merged commit be3a2b0 into hpcugent:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants