Fix test failure with glib 2.73.3 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a test failure when using glib 2.73.3. playerctl with glib 2.73.3 emits a deprecation warning and that is merged into the player list and the comparison with 'mpv' then fails. When mpv is not present, the reason for that still needs to be printed, so re-run the command when it failed or did not detect mpv is the player.
|
Thanks! |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 30, 2022
https://build.opensuse.org/request/show/1007097 by user mia + RBrownFactory - Update to 0.9 * expose musicbrainz metadata if available gh#hoyon/mpv-mpris#79 * Fix test failure with glib 2.73.3 gh#hoyon/mpv-mpris#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discard the playerctl stderr when listing players.
This fixes a test failure when using glib 2.73.3.
playerctl with glib 2.73.3 emits a deprecation warning and that is
merged into the player list and the comparison with 'mpv' then fails.
When mpv is not present, the reason for that still needs to be printed,
so re-run the command when it failed or did not detect mpv is the player.
Please make a new minor release after merging this pull request.