-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose musicbrainz metadata if available #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just a few comments
5812472
to
75db00a
Compare
Actually i need to update a bit more with this. I want to cover all the default separator options in Musicbrainz Picard. Which gives the options |
Actually, now that I review this I believe that the metadata should not be separated. That would be a job for any program consuming this data. There should be a single value for the Musicbrainz Album/Artist/etc. Id, also including any potential separators. This would make this PR much simpler. If you agree I'll force push some reversions. |
Yeah I think that makes sense. To be honest I'm not very familiar with music brainz so if you think that makes sense let's do it! |
75db00a
to
3dfbfa4
Compare
Okay I've got a bit more to work on this. Will let you know when it's ready. |
3dfbfa4
to
7983887
Compare
Ah apologies for not letting you know but this has been working for me for about a month. Thanks for merging. |
https://build.opensuse.org/request/show/1007097 by user mia + RBrownFactory - Update to 0.9 * expose musicbrainz metadata if available gh#hoyon/mpv-mpris#79 * Fix test failure with glib 2.73.3 gh#hoyon/mpv-mpris#80
I took a stab at exposing some musicbrainz metadata if it is present in
mpv. This will be useful for anyone who has tagged their music library
with Musicbrainz Picard and could be used in some scrobbling programs.