Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames: Ignore already cancelled submit events #459

Merged
merged 1 commit into from
Nov 22, 2021

Commits on Nov 21, 2021

  1. Frames: Ignore already cancelled submit events

    Closes [hotwired#243][]
    
    In tandem with [rails/rails#41960][] (which shipped as part of
    `7.0.0.alpha2`), this commit modifies the `FormInterceptor` to ignore
    `submit` events that have been cancelled.
    
    Although it doesn't test the integration directly, the cancellation of
    the `submit` event is what powers the ActiveStorage.js direct upload
    asynchrony. Following a direct upload, ActiveStorage dispatches a
    synthetic `submit` event, which the `FormInterceptor` will then respond
    to.
    
    [hotwired#243]: hotwired#243
    [rails/rails#41960]: rails/rails#41960
    seanpdoyle committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    19a1a74 View commit details
    Browse the repository at this point in the history