Frames: Ignore already cancelled submit events
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [hotwired#243][] In tandem with [rails/rails#41960][] (which shipped as part of `7.0.0.alpha2`), this commit modifies the `FormInterceptor` to ignore `submit` events that have been cancelled. Although it doesn't test the integration directly, the cancellation of the `submit` event is what powers the ActiveStorage.js direct upload asynchrony. Following a direct upload, ActiveStorage dispatches a synthetic `submit` event, which the `FormInterceptor` will then respond to. [hotwired#243]: hotwired#243 [rails/rails#41960]: rails/rails#41960
seanpdoyle
force-pushed
the
frame-ignored-cancelled-submit
branch
from
78270e6
to
19a1a74
Compare
|
So what happens if we ever DO want to have Turbo handle a previously default-prevented form submission? |
|
@CharlieIGG what are the circumstances under which Turbo would be handling an event that was canceled? ActiveStorage relies on cancelling the |
|
That actually makes perfect sense, thank you for the clarification @seanpdoyle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes hotwired/turbo#243
In tandem with rails/rails#41960 (which shipped as part of
7.0.0.alpha2), this commit modifies theFormInterceptorto ignoresubmitevents that have been cancelled.Although it doesn't test the integration directly, the cancellation of
the
submitevent is what powers the ActiveStorage.js direct uploadasynchrony. Following a direct upload, ActiveStorage dispatches a
synthetic
submitevent, which theFormInterceptorwill then respondto.