Improved: es.json by changing some translation which were in english(#410) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Feb 29, 2024
There was a problem hiding this comment.
small change. otherwise @ymaheshwari1 please review and merge
src/locales/es.json
Outdated
| @@ -172,7 +172,7 @@ | |||
| "Make sure all the items in this shipment are ready to be shipped. Once a shipment is completed, it cannot be edited.": "Make sure all the items in this shipment are ready to be shipped. Once a shipment is completed, it cannot be edited.", | |||
| "Make sure all the labels provided are correct.": "Asegúrate de que todas las etiquetas proporcionadas sean correctas.", | |||
| "Make sure all the mappings you have selected is correct.": "Asegúrate de que todas las asignaciones seleccionadas sean correctas.", | |||
| "Make sure you have entered the correct item quantities to create the shipment.": "Make sure you have entered the correct item quantities to create the shipment.", | |||
| "Make sure you have entered the correct item quantities to create the shipment.": "Asegúrese de haber ingresado las cantidades correctas de artículos para crear el envío..", | |||
There was a problem hiding this comment.
Suggested change
| "Make sure you have entered the correct item quantities to create the shipment.": "Asegúrese de haber ingresado las cantidades correctas de artículos para crear el envío..", | |
| "Make sure you have entered the correct item quantities to create the shipment.": "Asegúrese de haber ingresado las cantidades correctas de artículos para crear el envío.", |
ymaheshwari1
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #410
Short Description and Why It's Useful
Changed translations in es.json which were present in english for better experience.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance