Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP8.1 tentative return types #2

Merged

Conversation

ChristophWurst
Copy link
Contributor

PHP Deprecated:  Return type of Horde_Support_CaseInsensitiveArray::offsetExists($offset) should either be compatible with ArrayIterator::offsetExists(mixed $key): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/CaseInsensitiveArray.php on line 47
PHP Deprecated:  Return type of Horde_Support_CaseInsensitiveArray::offsetGet($offset) should either be compatible with ArrayIterator::offsetGet(mixed $key): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/CaseInsensitiveArray.php on line 27
PHP Deprecated:  Return type of Horde_Support_CaseInsensitiveArray::offsetSet($offset, $value) should either be compatible with ArrayIterator::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/CaseInsensitiveArray.php on line 36
PHP Deprecated:  Return type of Horde_Support_CaseInsensitiveArray::offsetUnset($offset) should either be compatible with ArrayIterator::offsetUnset(mixed $key): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/CaseInsensitiveArray.php on line 54
PHP Deprecated:  Return type of Horde_Support_Stub::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/Stub.php on line 126
PHP Deprecated:  Return type of Horde_Support_Stub::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/Stub.php on line 135
PHP Deprecated:  Return type of Horde_Support_Stub::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/Stub.php on line 111
PHP Deprecated:  Return type of Horde_Support_Stub::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/Stub.php on line 98
PHP Deprecated:  Return type of Horde_Support_Stub::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/Stub.php on line 105
PHP Deprecated:  Return type of Horde_Support_Stub::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/Imap_Client/Imap_Client/vendor/bytestream/horde-support/lib/Horde/Support/Stub.php on line 118

Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst pushed a commit to ChristophWurst/Horde_Support that referenced this pull request May 25, 2022
Copy link
Member

@mrubinsk mrubinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Hopefully we will eventually utilize the type declarations as we move to Horde 6 (and can thus break BC with ancient PHP versions, but this will help silence logs in the meantime.

@mrubinsk mrubinsk merged commit dd54425 into horde:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants