[Feature] [Gas] create a multi-asset ERC-721 vault #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
jake-nyquist
force-pushed
the
05-17-update_covered_call_impl_to_support_multiple_token_ids
branch
from
9caf758 to
8dd8283
Compare
jake-nyquist
force-pushed
the
05-18-create_multi-asset_erc-721_vault
branch
from
86762f4 to
2ad195a
Compare
This was referenced May 18, 2022
regynald
reviewed
May 18, 2022
Comment on lines
+16
to
+20
| /// @title HookMulitVault -- implemenation of a Vault for multiple assets within a NFT collection, with entitlements. | ||
| /// @author Jake Nyquist - [email protected] | ||
| /// @notice HookVault holds a multiple NFT asset in escrow on behalf of multiple beneficial owners. Other contracts | ||
| /// are able to register "entitlements" for a fixed period of time on the asset, which give them the ability to | ||
| /// change the vault's owner. |
There was a problem hiding this comment.
Can we take out and combine docs with IHookERC721MultiVault ?
There was a problem hiding this comment.
What is IHookERC721MultiVault? I don't think we have one, at least as of this commit.
src/HookERC721MultiVaultImplV1.sol
Outdated
| IERC721FlashLoanReceiver receiver = IERC721FlashLoanReceiver( | ||
| receiverAddress | ||
| ); | ||
| require(assetId == assetId, "flashLoan -- invalid asset id"); |
There was a problem hiding this comment.
Not sure what this require statement accomplishes
jake-nyquist
force-pushed
the
05-18-create_multi-asset_erc-721_vault
branch
from
96d605a to
02e5bab
Compare
regynald
approved these changes
May 19, 2022
This was referenced May 19, 2022
Closed
|
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: zj1dV246sIyY6mD9nEbE |
jake-nyquist
force-pushed
the
05-17-update_covered_call_impl_to_support_multiple_token_ids
branch
from
8dd8283 to
02bd7e9
Compare
jake-nyquist
changed the base branch from
05-17-update_covered_call_impl_to_support_multiple_token_ids
to
main
jake-nyquist
force-pushed
the
05-18-create_multi-asset_erc-721_vault
branch
from
02e5bab to
172ac4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vault takes a similar form to our current ERC-721 vault; however, instead of
requiring that a unique vault be deployed for each underlying ERC-721 token, this single
vault can support multiple tokenIds each with a distinct entitlement and a beneficial owner.
We believe this will result in substantial gas savings by removing the requirement that a
new vault is deployed for each minted option. Additionally, more care is taken in this
implementation to remove extraneous SSTOREs.
One area where we could get further SSTORE improvements would be by thining the
entitlement struct that we persist to not include the notion of the vault address, as the
vault adderss is the same for each asset within the vault.