migrate to assetId on the vault interface; #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
regynald
approved these changes
May 17, 2022
| @@ -23,30 +26,35 @@ import "../lib/Entitlements.sol"; | |||
| /// | |||
| interface IHookVault { | |||
| event EntitlementImposed( | |||
| uint256 assetId, | |||
| address entitledAccout, | |||
There was a problem hiding this comment.
Change to entitledAccount. Maybe also run a search for this just in case there are other typos
This was referenced May 17, 2022
jake-nyquist
force-pushed
the
05-17-migrate_to_assetId_on_the_vault_interface_
branch
from
3fbb64f to
6afd33d
Compare
This was referenced May 19, 2022
Closed
|
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: zj1dV246sIyY6mD9nEbE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR: show how we're going to modify the vault interface to support multiple assets
within the vaults