-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): V2 API client ratelimit improvements #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 78.63% 78.57% -0.07%
==========================================
Files 72 73 +1
Lines 5557 5606 +49
==========================================
+ Hits 4370 4405 +35
- Misses 901 910 +9
- Partials 286 291 +5 ☔ View full report in Codecov by Sentry. |
cewkrupa
approved these changes
Aug 1, 2024
dstrelau
reviewed
Aug 1, 2024
jharley
added a commit
that referenced
this pull request
Aug 1, 2024
I conflated the logic while hastily adding a test for jitter in #519. This fixes that flakey test by separating the two paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change teaches the V2 API client to respond to HTTP429s by backing off using the Ratelimit headers in the API's response.