Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 API Client gracefully handles rate limits observing Rate-Limit headers #511

Closed
jharley opened this issue Jul 29, 2024 · 0 comments · Fixed by #519
Closed

V2 API Client gracefully handles rate limits observing Rate-Limit headers #511

jharley opened this issue Jul 29, 2024 · 0 comments · Fixed by #519
Labels
feature This issue wants to add new functionality.

Comments

@jharley
Copy link
Collaborator

jharley commented Jul 29, 2024

The V2 API Client currently "just retries" when it receives a 429.

The headers for V2 APIs contain detail on when to retry and the total quota which should be used to determine when to try again.
@jharley jharley added the feature This issue wants to add new functionality. label Jul 29, 2024
@jharley jharley mentioned this issue Aug 1, 2024
Merged
@jharley jharley closed this as completed in cf2ca67 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue wants to add new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): V2 API client ratelimit improvements honeycombio/terraform-provider-honeycombio
1 participant
@jharley