Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alpine as base image #343

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

ismith
Copy link
Contributor

@ismith ismith commented Nov 1, 2021

Alpine is not that much bigger than google's distroless image. and
having this OS layer underneath will make it easier to debug.

(Currently: do we have a problem with the network interface name in our
config?)

Alpine is not _that_ much bigger than google's distroless image. and
having this OS layer underneath will make it easier to debug.
(Currently: do we have a problem with the network interface name in our
config?)
@ismith ismith requested a review from a team November 1, 2021 23:34
@ismith
Copy link
Contributor Author

ismith commented Nov 1, 2021

Test: run ./build-docker.sh, output contains:
2021/11/01 16:34:23 Using base alpine:3.13 for github.com/honeycombio/refinery/cmd/refinery

@ismith ismith force-pushed the make-refinery-docker-image-fat branch from 5183dbe to 3b409a2 Compare November 2, 2021 00:20
@Vlaaaaaaad
Copy link

I am very much in favour of this (it'll also make it easier to run Refinery using ECS on Fargate, related Slack thread here), but any chance something other than Alpine can be used?

Alpine is somewhat well known to have runtime issues due to musl. I had massive DNS issues in Kubernetes due to this, so I am now hyper-aware, even if some bugs were fixed.

Compared to Alpine's 2MB size, alternatives are indeed ten times bigger with Ubuntu images being ~27MB and Debian slim images being ~22MB, but I think the added size has minimal impact.

Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with changing the default image to alpine.

@ismith do you have an opinion on @Vlaaaaaaad's recommendation regarding Ubuntu/Debian images instead?

@robbkidd robbkidd added the status: info needed Further information is requested. label Nov 2, 2021
@MikeGoldsmith
Copy link
Contributor

@Vlaaaaaaad I'm going to merge this PR using alpine as base image. Please raise an issue if you feel you'd still like use to consider us using another base image.

@MikeGoldsmith MikeGoldsmith merged commit 7614a6e into main Nov 4, 2021
@MikeGoldsmith MikeGoldsmith deleted the make-refinery-docker-image-fat branch November 4, 2021 12:32
@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. and removed status: info needed Further information is requested. labels Nov 4, 2021
MikeGoldsmith added a commit that referenced this pull request Nov 9, 2021
* 'main' of github.com:honeycombio/refinery:
  prepare v1.6.0 release (#348)
  bump libhoney-go to v1.15.6 (#347)
  Use alpine as base image (#343)
  empower apply-labels action to apply labels (#344)
  Add an --interface-names flag (#342)

# Conflicts:
#	go.mod
#	go.sum
JamieDanielson added a commit that referenced this pull request Nov 10, 2021
JamieDanielson added a commit that referenced this pull request Nov 10, 2021
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants