-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alpine as base image #343
Conversation
Alpine is not _that_ much bigger than google's distroless image. and having this OS layer underneath will make it easier to debug. (Currently: do we have a problem with the network interface name in our config?)
Test: run |
5183dbe
to
3b409a2
Compare
I am very much in favour of this (it'll also make it easier to run Refinery using ECS on Fargate, related Slack thread here), but any chance something other than Alpine can be used? Alpine is somewhat well known to have runtime issues due to Compared to Alpine's 2MB size, alternatives are indeed ten times bigger with Ubuntu images being ~27MB and Debian slim images being ~22MB, but I think the added size has minimal impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with changing the default image to alpine.
@ismith do you have an opinion on @Vlaaaaaaad's recommendation regarding Ubuntu/Debian images instead?
@Vlaaaaaaad I'm going to merge this PR using alpine as base image. Please raise an issue if you feel you'd still like use to consider us using another base image. |
This reverts commit 7614a6e.
This reverts commit 7495c88.
Alpine is not that much bigger than google's distroless image. and
having this OS layer underneath will make it easier to debug.
(Currently: do we have a problem with the network interface name in our
config?)