fix(network): NoSessionId Error (nervosnetwork#33)

Crate creep Context `with_value()` return value must be used.
homura · Sep 25, 2019 · 4761d79 · 4761d79
1 parent c8404bb
commit 4761d79
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/network/src/reactor/mod.rs b/core/network/src/reactor/mod.rs
@@ -63,8 +63,7 @@ where
         let SessionMessage { sid, msg: net_msg } = smsg;
 
         let endpoint = net_msg.url.to_owned();
-        let mut ctx = Context::new();
-        ctx.set_session_id(sid);
+        let mut ctx = Context::new().set_session_id(sid);
 
         let react = async move {
             let endpoint = net_msg.url.parse::<Endpoint>()?;
@@ -75,7 +74,7 @@ where
                 EndpointScheme::RpcCall => {
                     let rpc_endpoint = RpcEndpoint::try_from(endpoint)?;
 
-                    ctx.set_rpc_id(rpc_endpoint.rpc_id().value());
+                    let ctx = ctx.set_rpc_id(rpc_endpoint.rpc_id().value());
                     handler.process(ctx, content).await?
                 }
                 EndpointScheme::RpcResponse => {

diff --git a/core/network/src/traits.rs b/core/network/src/traits.rs
@@ -57,6 +57,7 @@ impl NetworkContext for Context {
             .ok_or_else(|| ErrorKind::NoSessionId.into())
     }
 
+    #[must_use]
     fn set_session_id(&mut self, sid: SessionId) -> Self {
         self.with_value::<CtxSessionId>("session_id", CtxSessionId(sid))
     }
@@ -67,6 +68,7 @@ impl NetworkContext for Context {
             .ok_or_else(|| ErrorKind::NoRpcId.into())
     }
 
+    #[must_use]
     fn set_rpc_id(&mut self, rid: u64) -> Self {
         self.with_value::<CtxRpcId>("rpc_id", CtxRpcId(rid))
     }