This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
doc: auto gen api #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yejiayu
previously approved these changes
Oct 28, 2019
cryptowen
reviewed
Oct 28, 2019
core/api/src/schema/epoch.rs
Outdated
| pub chain_id: Hash, | ||
| #[graphql(description = "Known as the block height like other blockchain")] | ||
| pub epoch_id: Uint64, | ||
| #[graphql(description = "The merkle root of the previous epoch")] |
There was a problem hiding this comment.
Suggested change
| #[graphql(description = "The merkle root of the previous epoch")] | |
| #[graphql(description = "Previous epoch hash")] |
This is a hash, not a mercke root.
There was a problem hiding this comment.
OK, I have make the description more clearly now
yejiayu
approved these changes
Oct 28, 2019
KaoImin
approved these changes
Oct 29, 2019
yejiayu
pushed a commit
to yejiayu/muta
that referenced
this pull request
Oct 31, 2019
Crate creep Context `with_value()` return value must be used.
yejiayu
pushed a commit
to yejiayu/muta
that referenced
this pull request
Oct 31, 2019
…ork#33) * doc: auto gen api * doc: make the field description more clear
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
doc
What this PR does / why we need it:
Supports auto generating docs
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: