-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stookwijzer integration #30033
Closed
fwestenberg
wants to merge
136
commits into
home-assistant:next
from
fwestenberg:Update-stookwijzer-integration
Closed
Update stookwijzer integration #30033
fwestenberg
wants to merge
136
commits into
home-assistant:next
from
fwestenberg:Update-stookwijzer-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Improve IMAP integration SSL settings copy * Do not add a remark this is dangerous --------- Co-authored-by: Jan Bouwhuis <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add blog about myq * remove forum link * Update source/_posts/2023-11-06-removal-of-myq-integration.markdown Co-authored-by: Franck Nijhof <[email protected]> --------- Co-authored-by: Franck Nijhof <[email protected]>
update `state_topic` example to match using the device topic
* Assist: about wake words: add approach - add some comceptual information about the Home Assistant approach to realize wake words - Content source: Bog post https://www.home-assistant.io/blog/2023/10/12/year-of-the-voice-chapter-4-wakewords/ * Apply suggestions from code review Co-authored-by: Michael Hansen <[email protected]> --------- Co-authored-by: Michael Hansen <[email protected]>
* Add note about active connection for battery * Tiny tweak --------- Co-authored-by: c0ffeeca7 <[email protected]>
- fixes error I missed in review of home-assistant#29705
) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fwestenberg
requested review from
kellerza,
a team,
dshokouhi,
Santobert,
jbouwh,
pnbruckner,
farmio,
marvin-w,
teharris1,
mdegat01,
zxdavb,
danielperna84,
klaasnicolaas,
cgarwood,
cdce8p,
OttoWinter,
jesserockz,
OverloadUT and
ochlocracy
as code owners
November 28, 2023 11:34
home-assistant
bot
removed
current
This PR goes into the current branch
needs-rebase
The PR has been branched of the wrong base branch or targets an incorrect target branch
labels
Nov 28, 2023
jbouwh
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to rebase out all unrelated commits and start a new PR.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
removed
the
in-progress
This PR/Issue is currently being worked on
label
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The API has changed, also the different advices are added (source https://iplo.nl/thema/lucht/houtstook-de-stookwijzer-en-het-stookalert/)
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.