-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stookwijzer api to atlas leefomgeving #103323
Merged
joostlek
merged 12 commits into
home-assistant:dev
from
fwestenberg:Update-Stookwijzer-api-to-Atlas-Leefomgeving
Nov 28, 2023
Merged
Update stookwijzer api to atlas leefomgeving #103323
joostlek
merged 12 commits into
home-assistant:dev
from
fwestenberg:Update-Stookwijzer-api-to-Atlas-Leefomgeving
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: stookwijzer
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Nov 3, 2023
joostlek
requested changes
Nov 3, 2023
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <[email protected]>
joostlek
reviewed
Nov 3, 2023
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
joostlek
approved these changes
Nov 28, 2023
By the way, should the docs be updated as well? |
This was referenced Nov 28, 2023
Docs are just updated. |
8 tasks
20 tasks
I added a commit diff link of the library bump in the PR description. This was missing. |
20 tasks
frenck
added a commit
that referenced
this pull request
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking-change
bugfix
by-code-owner
cla-signed
integration: stookwijzer
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Stookwijzer states are updated. New possible states are: code_yellow, code_orange and code_red.
Proposed change
The API is updated at the source, so changes were necessary to keep te integration working.
fwestenberg/stookwijzer@v1.3.0...v1.4.2
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: