Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stookwijzer api to atlas leefomgeving #103323

Conversation

fwestenberg
Copy link
Contributor

@fwestenberg fwestenberg commented Nov 3, 2023

Breaking change

Stookwijzer states are updated. New possible states are: code_yellow, code_orange and code_red.

Proposed change

The API is updated at the source, so changes were necessary to keep te integration working.

fwestenberg/stookwijzer@v1.3.0...v1.4.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • [x]I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/stookwijzer/const.py Outdated Show resolved Hide resolved
homeassistant/components/stookwijzer/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 3, 2023 16:02
@home-assistant
Copy link

home-assistant bot commented Nov 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@fwestenberg fwestenberg marked this pull request as ready for review November 28, 2023 07:59
@home-assistant home-assistant bot requested a review from joostlek November 28, 2023 07:59
@joostlek
Copy link
Member

By the way, should the docs be updated as well?

@fwestenberg
Copy link
Contributor Author

By the way, should the docs be updated as well?

Docs are just updated.

@joostlek joostlek merged commit 9dc5d4a into home-assistant:dev Nov 28, 2023
50 checks passed
@fwestenberg fwestenberg deleted the Update-Stookwijzer-api-to-Atlas-Leefomgeving branch November 28, 2023 14:39
@MartinHjelmare
Copy link
Member

I added a commit diff link of the library bump in the PR description. This was missing.

frenck added a commit that referenced this pull request Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changed site
3 participants