Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change slider direction in cover tile position feature #17705

Closed

Conversation

Misiu
Copy link
Contributor

@Misiu Misiu commented Aug 25, 2023

Breaking change

Proposed change

Alternative to: #17687
This changes the slider direction, we now show the active zone as the close value (same as in more info), but we keep the consistency with other features (0% on the left, 100% on the right)

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya
Copy link
Member

piitaya commented Aug 28, 2023

This change was already proposed in the original PR : #16110 (comment).

I discussed with the UX team and we prefer to keep the current behavior for now rather to add option.

@frenck
Copy link
Member

frenck commented Oct 9, 2023

Thanks for the contribution, as per above, we decided not to do this.

Nevertheless, thanks for being willing to contribute.

../Frenck

@frenck frenck closed this Oct 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants