Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing direction of slider in cover position tile feature #17687

Closed
wants to merge 3 commits into from

Conversation

Misiu
Copy link
Contributor

@Misiu Misiu commented Aug 23, 2023

Breaking change

Proposed change

This change will allow the user to change the direction of the slider in the cover position tile feature:

image

image

image

It still follows the rule that we should use the active zone from more info (in this case the active zone shows the close percentage), but it allows us to have 0% on the left.

Ideally, this should be the default behavior, because it uses the close percentage as an active zone and it allows consistent UI/UX - 0% is on the left as in all other tile features.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Misiu Misiu mentioned this pull request Aug 24, 2023
9 tasks
@piitaya
Copy link
Member

piitaya commented Aug 28, 2023

This change was already proposed in the original PR : #16110 (comment).

I discussed with the UX team and we prefer to keep the current behavior for now rather to add option.

@frenck
Copy link
Member

frenck commented Oct 9, 2023

Thanks for the contribution, as per above, we decided not to do this.

Nevertheless, thanks for being willing to contribute.

../Frenck

@frenck frenck closed this Oct 9, 2023
@Misiu
Copy link
Contributor Author

Misiu commented Oct 9, 2023

No worries :)
I plan to release this as a custom tile feature.
Sorry for not closing this before.

@jonferreira
Copy link

Thanks for the contribution, as per above, we decided not to do this.

Nevertheless, thanks for being willing to contribute.

../Frenck

While I can understand the decision to keep the same default behaviour, I don't understand why an option to invert the slider is not allowed?

IMHO the slider on a 100% opened cover should be represented the same way as a 100% dimmable light, i.e. slider fully to the right. Again, I understand everyone has their opinion and this may not make sense to some people but I'd love to have an option to "invert" the slider bahviour.

@piitaya
Copy link
Member

piitaya commented Feb 12, 2024

@jonferreira We didn't add the option because we don't want to multiply the number of option for each card or card features.
However, it's totally possible to create a custom feature for this behavior (see documentation).

@jhemak
Copy link

jhemak commented Sep 7, 2024

I think this would be a great feature. I also find it confusing to have 100% on the left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants