Add custom bypass night arming to SIA alarm codes

[etnoy]

Proposed change

Type of change

This PR was reviewed before as #80287 but never merged.

Within the SIA alarm codes (used in the Ajax alarm system) it is possible to arm with bypass. This is useful if a malfunction is detected but acknowledged by the user. However, if a malfunction is detected within night arming, the resulting state in HA will be Unknown. This change maps custom_bypass arming in night mode to armed_custom_byass.

Pinging @eavanvalkenburg

fixes #95279

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @eavanvalkenburg, mind taking a look at this pull request as it has been labeled with an integration (sia) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sia can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign sia Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[eavanvalkenburg]

LGTM

[etnoy]

LGTM

Thanks, Eduard. How do we make sure this gets merged so it doesn't get abandoned like the last PR?

[gjohansson-ST]

Would it not make more sense to make it STATE_ALARM_ARMED_CUSTOM_BYPASS even if it's night?

Please also rebase this PR to remove the unwanted commits.

[etnoy]

Would it not make more sense to make it STATE_ALARM_ARMED_CUSTOM_BYPASS even if it's night?

Please also rebase this PR to remove the unwanted commits.

The SIA codes being added here are previously-unknown to HA. Night mode uses other codes as far I can tell from the Ajax docs

[gjohansson-ST]

The SIA codes being added here are previously-unknown to HA. Night mode uses other codes as far I can tell from the Ajax docs

Sure, the new codes you are now mapping to STATE_ALARM_ARMED_NIGHT. I suggest you change that to STATE_ALARM_ARMED_CUSTOM_BYPASS even if it's during night (as you have explained the reasoning in the pr description)
Don't have a strong opinion here so if you guys prefer to keep it with STATE_ALARM_ARMED_NIGHT I'm fine with that.

[gjohansson-ST]

@etnoy something is still not right with the rebase as there are now 140 commits on it.

[etnoy]

@etnoy something is still not right with the rebase as there are now 140 commits on it.

Oh no. I just looked at "files changed" and was satisified. Ideally I'd just create a fresh branch from dev, but this seems hard now that it's part of a PR. Any suggestions? I feel like I've dug myself into a hole (the change is literally just two lines)

[gjohansson-ST]

I suggest you open a new PR and close this one.
You can ping me in the new one.

[etnoy]

Thanks for the assistance, @gjohansson-ST