Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIA codes for night arming with custom bypass #80287

Closed
wants to merge 1 commit into from

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Oct 13, 2022

Proposed change

Within the SIA alarm system (used in the Ajax alarm system) it is possible to arm with bypass. This is useful if a malfunction is detected but acknowledged by the user. However, if a malfunction is detected within night arming, the resulting state in HA will be Unknown. This change maps custom_bypass arming in night mode to armed_night.

Ideally, there would be a ARMED_NIGHT_CUSTOM_BYPASS mode, but that is not available. Therefore, we propose mapping custom_bypass arming in night mode to ARMED_NIGHT.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi etnoy

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @eavanvalkenburg, mind taking a look at this pull request as it has been labeled with an integration (sia) you are listed as a code owner for? Thanks!

@etnoy
Copy link
Contributor Author

etnoy commented Oct 13, 2022

The CLA site appears down and returns HTTP error 500 when submitting the signature. I will retry in the coming days

@eavanvalkenburg
Copy link
Contributor

LGTM

@frenck frenck added smash Indicator this PR is close to finish for merging or closing hacktoberfest-accepted labels Oct 24, 2022
Copy link

@kevin-brown kevin-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Confirmed NF is present in standard SIA code list and NE is listed within the Ajax-specific SIA code list. Mapping seems reasonable given code descriptions.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 18, 2023
@github-actions github-actions bot closed this Mar 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed hacktoberfest-accepted integration: sia new-feature Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants