Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure due to integrations leaving dirty known_devices.yaml #74329

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

thecode
Copy link
Member

@thecode thecode commented Jul 2, 2022

Proposed change

Fix broken CI due to multiple integrations and tests accessing/creating known_devices.yaml file and eventually leaving it behind when test ends.
After long debugging the main issue was missing await hass.async_block_till_done() in one of the device tracker tests. To reduce chances for failures two additional places which creates this file also cleaned-up.

Thanks @epenet with #74255 which helped pinning this issue.

History of debugging this issue can be found on #74278

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thecode thecode added the ci-full-run Marks a PR to trigger a full CI run (instead of partial) label Jul 2, 2022
@thecode thecode requested a review from a team as a code owner July 2, 2022 15:49
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (device_tracker) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@@ -165,6 +166,7 @@ async def test_setup_without_yaml_file(hass, enable_custom_integrations):
"""Test with no YAML file."""
with assert_setup_component(1, device_tracker.DOMAIN):
assert await async_setup_component(hass, device_tracker.DOMAIN, TEST_PLATFORM)
await hass.async_block_till_done()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭😭😭

@balloob balloob merged commit d56a487 into home-assistant:dev Jul 2, 2022
@thecode thecode deleted the fix-ci-yaml-leftovers branch July 2, 2022 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2022
@balloob balloob added this to the 2022.7.2 milestone Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants