Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent integrations from creating known_devices.yaml #74278

Closed

Conversation

thecode
Copy link
Member

@thecode thecode commented Jun 30, 2022

Proposed change

Fix broken CI due to multiple integrations and tests accessing/creating known_devices.yaml file and eventually leaving it behind when test ends.

Note: By changing then number of tests run in parrallel I can cause two of the device tracker tests to access this file at the same time and fail. To eliminate this I removed one of the tests from accessing the file:
https://github.com/thecode/core/blob/c15595314fdbcc7cf817a12f599d382d24f00753/tests/components/device_tracker/test_init.py#L98

In order to have at least one test that access legacy.update_config the following test is still creating this file:
https://github.com/thecode/core/blob/c15595314fdbcc7cf817a12f599d382d24f00753/tests/components/device_tracker/test_init.py#L415

So eventually there is still one tests that creates the known_devices.yaml and deletes at the end of the test.

Thanks @epenet with #74255 which helped pinning this issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (device_tracker) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@thecode thecode added the ci-full-run Marks a PR to trigger a full CI run (instead of partial) label Jun 30, 2022
@thecode thecode closed this Jun 30, 2022
@thecode thecode reopened this Jun 30, 2022
@thecode thecode marked this pull request as draft June 30, 2022 22:08
@thecode thecode closed this Jul 1, 2022
@thecode thecode reopened this Jul 1, 2022
@thecode thecode removed the request for review from a team July 1, 2022 15:04
@epenet epenet mentioned this pull request Jul 2, 2022
22 tasks
@thecode thecode closed this Jul 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2022
@thecode thecode deleted the prevent-known-devices-leftovers branch October 20, 2022 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix ci-full-run Marks a PR to trigger a full CI run (instead of partial) cla-signed core has-tests integration: demo integration: device_tracker small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants