-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent integrations from creating known_devices.yaml #74278
Closed
thecode
wants to merge
27
commits into
home-assistant:dev
from
thecode:prevent-known-devices-leftovers
Closed
Prevent integrations from creating known_devices.yaml #74278
thecode
wants to merge
27
commits into
home-assistant:dev
from
thecode:prevent-known-devices-leftovers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
core
has-tests
integration: device_tracker
integration: demo
small-pr
PRs with less than 30 lines.
labels
Jun 30, 2022
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
thecode
added
the
ci-full-run
Marks a PR to trigger a full CI run (instead of partial)
label
Jun 30, 2022
22 tasks
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
ci-full-run
Marks a PR to trigger a full CI run (instead of partial)
cla-signed
core
has-tests
integration: demo
integration: device_tracker
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix broken CI due to multiple integrations and tests accessing/creating
known_devices.yaml
file and eventually leaving it behind when test ends.Note: By changing then number of tests run in parrallel I can cause two of the device tracker tests to access this file at the same time and fail. To eliminate this I removed one of the tests from accessing the file:
https://github.com/thecode/core/blob/c15595314fdbcc7cf817a12f599d382d24f00753/tests/components/device_tracker/test_init.py#L98
In order to have at least one test that access
legacy.update_config
the following test is still creating this file:https://github.com/thecode/core/blob/c15595314fdbcc7cf817a12f599d382d24f00753/tests/components/device_tracker/test_init.py#L415
So eventually there is still one tests that creates the
known_devices.yaml
and deletes at the end of the test.Thanks @epenet with #74255 which helped pinning this issue.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: