-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add select platform to Renault integration #55494
Conversation
cc @MartinHjelmare as requested in PR #54820 (comment https://github.com/home-assistant/core/pull/54820/files#r699062608) |
Is this a new feature? or a breaking change? |
Since we're moving a sensor value to a select entity, it'll be a breaking change. |
Thanks it confirms what I expected. |
9c849ee
to
bb42ba7
Compare
Rebased on latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I've created the docs PR: home-assistant/home-assistant.io#19160 |
Thanks |
Breaking change
sensor.charge_mode
has been moved toselect.charge_mode
(note:unique_id
is unchanged)Proposed change
Add
select
platform to Renault integrationType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: