Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tracker platform to Renault integration #54745

Merged
merged 15 commits into from
Sep 1, 2021

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 17, 2021

Breaking change

Extra state attribute last_update has been normalised to UTC

Proposed change

Add device tracker platform to Renault integration, as follow up to #39605

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet changed the title Add device tracker to Renault integration Add device tracker platform to Renault integration Aug 17, 2021
@epenet epenet force-pushed the renault-device-tracker branch from 144d861 to 9666474 Compare August 19, 2021 07:53
@epenet epenet mentioned this pull request Aug 25, 2021
22 tasks
@epenet epenet force-pushed the renault-device-tracker branch from 3babdaf to 07f37b8 Compare August 26, 2021 10:17
@epenet epenet marked this pull request as draft August 26, 2021 12:14
@epenet
Copy link
Contributor Author

epenet commented Aug 26, 2021

Will need to be rebased after #55230

@epenet
Copy link
Contributor Author

epenet commented Aug 27, 2021

Will need to be rebased after #55313

@epenet epenet force-pushed the renault-device-tracker branch from bf94f71 to c60aeb7 Compare August 27, 2021 10:28
@epenet epenet marked this pull request as ready for review August 27, 2021 10:28
@epenet epenet mentioned this pull request Aug 27, 2021
22 tasks
@epenet epenet force-pushed the renault-device-tracker branch from c60aeb7 to d3392ca Compare August 31, 2021 12:14
@epenet
Copy link
Contributor Author

epenet commented Aug 31, 2021

Rebased following merge of #55454

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please add a breaking change paragraph for the change of the timestamp string for last update state attribute.

@MartinHjelmare MartinHjelmare merged commit bcf97cb into home-assistant:dev Sep 1, 2021
@epenet
Copy link
Contributor Author

epenet commented Sep 1, 2021

Thanks @MartinHjelmare

@epenet epenet deleted the renault-device-tracker branch September 1, 2021 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants