-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device tracker platform to Renault integration #54745
Merged
MartinHjelmare
merged 15 commits into
home-assistant:dev
from
epenet:renault-device-tracker
Sep 1, 2021
Merged
Add device tracker platform to Renault integration #54745
MartinHjelmare
merged 15 commits into
home-assistant:dev
from
epenet:renault-device-tracker
Sep 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
144d861
to
9666474
Compare
22 tasks
3babdaf
to
07f37b8
Compare
Will need to be rebased after #55230 |
Will need to be rebased after #55313 |
bf94f71
to
c60aeb7
Compare
22 tasks
c60aeb7
to
d3392ca
Compare
Rebased following merge of #55454 |
MartinHjelmare
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please add a breaking change paragraph for the change of the timestamp string for last update state attribute.
Thanks @MartinHjelmare |
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Extra state attribute
last_update
has been normalised to UTCProposed change
Add device tracker platform to Renault integration, as follow up to #39605
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: