-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roomba support for automatic emptying of bin #43594
Conversation
…phase` to `evac` when doing so. This adds a state mapping from `evac` to `STATE_CLEANING` so that the correct data ends up in home assistant. Previously this state would map to `STATE_ERROR`.
Hi @jasperslits, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just the lint failure that needs addressed before merging.
So, this change relies on Roombapy 1.6.2, which we don't have? |
Seems I am messing up this fairly trivial PR after not paying attention. I also added a commit to bump the dependency to 1.6.2 roombapy with carries the 'evac' missing key as well as a lot of other entries. @pschmitt : mind helping out here as this is related the release you did yesterday? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to replace the from roomba
imports with from roombapy
.
@pschmitt : thanks for the pointer. Took a few spins before all tests are passed, so it was a bit of a learning experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Proposed change
Roomba i7+ and s9+ are capable of auto emptying, and will set their
phase
toevac
when doing so. This adds a state mapping fromevac
toSTATE_RETURNING
so that the correct data ends up in home assistant. Previously this state would map toSTATE_ERROR
. #roombaSTATE_CLEANING
was considered butSTATE_RETURNING
seems better asSTATE_CLEANING
refers to actively vacuuming the floor and not cleaning the bin. Thisevac
state typically lasts 10 seconds.Roombapy support for evac status will be delivered in 1.6.2
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
See also PR Add roomba support for automatic emptying #39913 (already closed due to inactivity).
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: