Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roomba support for automatic emptying of bin #43594

Merged
merged 5 commits into from
Nov 26, 2020
Merged

Add Roomba support for automatic emptying of bin #43594

merged 5 commits into from
Nov 26, 2020

Conversation

jasperslits
Copy link
Contributor

@jasperslits jasperslits commented Nov 24, 2020

Proposed change

Roomba i7+ and s9+ are capable of auto emptying, and will set their phase to evac when doing so. This adds a state mapping from evac to STATE_RETURNING so that the correct data ends up in home assistant. Previously this state would map to STATE_ERROR. #roomba
STATE_CLEANING was considered but STATE_RETURNING seems better as STATE_CLEANING refers to actively vacuuming the floor and not cleaning the bin. This evac state typically lasts 10 seconds.
Roombapy support for evac status will be delivered in 1.6.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

…phase` to `evac` when doing so. This adds a state mapping from `evac` to `STATE_CLEANING` so that the correct data ends up in home assistant. Previously this state would map to `STATE_ERROR`.
@homeassistant
Copy link
Contributor

Hi @jasperslits,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the lint failure that needs addressed before merging.

@frenck
Copy link
Member

frenck commented Nov 24, 2020

So, this change relies on Roombapy 1.6.2, which we don't have?
Why isn't this PR updating the dependency in that case?

@jasperslits
Copy link
Contributor Author

Seems I am messing up this fairly trivial PR after not paying attention.

I also added a commit to bump the dependency to 1.6.2 roombapy with carries the 'evac' missing key as well as a lot of other entries.

@pschmitt : mind helping out here as this is related the release you did yesterday?

Copy link
Contributor

@pschmitt pschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace the from roomba imports with from roombapy.

@jasperslits
Copy link
Contributor Author

@pschmitt : thanks for the pointer. Took a few spins before all tests are passed, so it was a bit of a learning experience.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@frenck frenck merged commit f3033ec into home-assistant:dev Nov 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants