-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roomba support for automatic emptying #39913
Conversation
Roomba i7+ and s9+ are capable of auto emptying, and will set their `phase` to `evac` when doing so. This adds a state mapping from `evac` to `STATE_CLEANING` so that the correct data ends up in home assistant. Previously this state would map to `STATE_ERROR`.
Fixing the flake8 check and it should be good to go. Also, I think |
@@ -51,6 +51,7 @@ | |||
STATE_MAP = { | |||
"": STATE_IDLE, | |||
"charge": STATE_DOCKED, | |||
"evac": STATE_CLEANING, # Emptying at cleanbase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"evac": STATE_CLEANING, # Emptying at cleanbase | |
"evac": STATE_RETURNING, # Emptying at cleanbase |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Roomba i7+ and s9+ are capable of auto emptying, and will set their
phase
toevac
when doing so. This adds a state mapping fromevac
toSTATE_CLEANING
so that the correct data ends up in home assistant. Previously this state would map toSTATE_ERROR
.Type of change
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: