Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roomba support for automatic emptying #39913

Closed
wants to merge 1 commit into from

Conversation

thomaspurchas
Copy link

Proposed change

Roomba i7+ and s9+ are capable of auto emptying, and will set their phase to evac when doing so. This adds a state mapping from evac to STATE_CLEANING so that the correct data ends up in home assistant. Previously this state would map to STATE_ERROR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Roomba i7+ and s9+ are capable of auto emptying, and will set their `phase` to `evac` when doing so. This adds a state mapping from `evac` to `STATE_CLEANING` so that the correct data ends up in home assistant. Previously this state would map to `STATE_ERROR`.
@probot-home-assistant
Copy link

Hey there @pschmitt, @cyr-ius, @shenxn, mind taking a look at this pull request as its been labeled with an integration (roomba) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@shenxn
Copy link
Contributor

shenxn commented Sep 11, 2020

Fixing the flake8 check and it should be good to go. Also, I think STATE_RETURNING might be better than STATE_CLEANING in representing the state.

@@ -51,6 +51,7 @@
STATE_MAP = {
"": STATE_IDLE,
"charge": STATE_DOCKED,
"evac": STATE_CLEANING, # Emptying at cleanbase
Copy link
Contributor

@shenxn shenxn Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"evac": STATE_CLEANING, # Emptying at cleanbase
"evac": STATE_RETURNING, # Emptying at cleanbase

@MartinHjelmare MartinHjelmare changed the title Add support for automatic emptying Add roomba support for automatic emptying Sep 11, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants