-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update voluptuous to 0.12.0 #40401
Update voluptuous to 0.12.0 #40401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated a few installs and nothing unexpected showed up.
This looks like a safe set of changes.
As I opened a PR for dependency upgrade as well and ran some |
I think those libraries would need to adjust their dependencies, by either specifying =0.12.0 or >= 0.11.7. Having multiple versions of the same library is not possible via pip as far as I am aware. |
Ah I see now that
Indeed, so we need to wait a bid until this can be resolved. And now I see how you recognised that release instantly 😄. We might want to open a PR on those three module repos as well now? 😉 |
Yeah, I was involved in getting that release voluptuous 0.12.0 out of the door hence my quick PR here in HA 😄. Feel free to create those PRs for the other module repos. |
The first is already done by dependabot: bachya/simplisafe-python#174 👍 |
FYI: |
Breaking change
Proposed change
The main reason for updating is that the new version incorporates fixes to
Range
,Clamp
andLength
when invalid types are used. E.g. if you try to pass a string to thecount
attribute of theping
binary sensor, it previously caused a crash, whereas now we get back an error log entry in the HA log from the library.My commit to update the voluptuous change log is still pending but contains the detailed changes: alecthomas/voluptuous#428
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: