Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voluptuous to 0.12.0 #40401

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Sep 21, 2020

Breaking change

Proposed change

The main reason for updating is that the new version incorporates fixes to Range, Clamp and Length when invalid types are used. E.g. if you try to pass a string to the count attribute of the ping binary sensor, it previously caused a crash, whereas now we get back an error log entry in the HA log from the library.

My commit to update the voluptuous change log is still pending but contains the detailed changes: alecthomas/voluptuous#428

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated a few installs and nothing unexpected showed up.

This looks like a safe set of changes.

@bdraco bdraco merged commit 2a4d7dc into home-assistant:dev Sep 21, 2020
@spacegaier spacegaier deleted the vol-0.12.0 branch September 21, 2020 15:58
@MichaIng
Copy link

MichaIng commented Sep 23, 2020

As I opened a PR for dependency upgrade as well and ran some pip3 check, I found three dependency conflicts caused by this PR, please have a look at: #40479 (comment)

@spacegaier
Copy link
Member Author

As I opened a PR for dependency upgrade as well and ran some pip3 check, I found three dependency conflicts caused by this PR, please have a look at: #40479 (comment)

I think those libraries would need to adjust their dependencies, by either specifying =0.12.0 or >= 0.11.7. Having multiple versions of the same library is not possible via pip as far as I am aware.

@MichaIng
Copy link

MichaIng commented Sep 23, 2020

Ah I see now that 0.12.0 was released just two days ago and 0.11.7 was the latest version until then: https://pypi.org/project/voluptuous/#history

Indeed, so we need to wait a bid until this can be resolved.

And now I see how you recognised that release instantly 😄. We might want to open a PR on those three module repos as well now? 😉

@spacegaier
Copy link
Member Author

And now I see how you recognised that release instantly 😄. We might want to open a PR on those three module repos as well now? 😉

Yeah, I was involved in getting that release voluptuous 0.12.0 out of the door hence my quick PR here in HA 😄. Feel free to create those PRs for the other module repos.

@MichaIng
Copy link

The first is already done by dependabot: bachya/simplisafe-python#174 👍
Second: ahayworth/python_awair#17
Third: bachya/aioguardian#61

@MichaIng
Copy link

FYI: python_awair now supports voluptuous 0.12.0 as well: ahayworth/python_awair#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants