Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voluptuous requirement from ^0.11.7 to >=0.11.7,<0.13.0 #17

Merged
merged 3 commits into from
Oct 25, 2020
Merged

Update voluptuous requirement from ^0.11.7 to >=0.11.7,<0.13.0 #17

merged 3 commits into from
Oct 25, 2020

Conversation

MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Sep 23, 2020

Updates the requirements on voluptuous to permit the latest version.

For reference:

About CI build errors, not sure what the issue is since the syntax for giving a version range matches the ones that are already present, e.g.:

[package.dependencies.typed-ast]
python = "<3.8"
version = ">=1.4.0,<1.5"

Please advice and I'll push the fix.

@ahayworth
Copy link
Owner

ahayworth commented Oct 25, 2020

Hey @MichaIng - sorry for missing this! Apparently I wasn't subscribed to all updates on my own repo. 🤦 🤦

So the problem here is that poetry is unable to parse the syntax in the poetry.lock file - and that's because setting a range in the poetry.lock file is the wrong workflow. It represents the exact set of dependencies that were installed, creating a reproducible dev environment. That's naturally incompatible with a range of dependencies - but the confusion here makes sense to me because Poetry operates rather differently than the pip requirements.txt workflow.

However, setting a range of dependencies is allowed - you just have to set it only in pyproject.toml - which represents what is allowed for the project. Then you install/update, poetry picks a version according to the range specified, and then you commit the generated changes. 😄

Specifically, the workflow is:

  1. Change the version in pyproject.toml (which you did, excellent!)
  2. Run poetry update voluptuous
  3. Commit the re-generated poetry.lock

I've pushed two commits to your branch - one to reset the poetry.lock to before the PR, and then another to regenerate it with poetry update voluptuous. We'll see if it builds. 😄

@ahayworth
Copy link
Owner

Woohoo, that worked. Thank you for noticing that this needed to be updated! 😄

@ahayworth ahayworth merged commit af69891 into ahayworth:master Oct 25, 2020
@MichaIng
Copy link
Contributor Author

Many thanks, yes I was guessing that I missed something around the requirements.txt itself, so the PR did it's job to make you aware of the voluptuous update. Thanks for explaining the poetry steps, I can make my PRs better/complete in the future 🙂.

@MichaIng MichaIng deleted the patch-1 branch October 25, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants