-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move imports up #27288
Move imports up #27288
Conversation
8e60d6e
to
761d7f2
Compare
@@ -11,7 +13,6 @@ | |||
def setup(hass, config): | |||
"""Set up the BeagleBone Black GPIO component.""" | |||
# pylint: disable=import-error | |||
from Adafruit_BBIO import GPIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this incarnation of the impl will leave a bunch of those # pylint: disable=import-error
s behind; they should be cleaned up one way or another (either moved to end of the import line if still needed, or removed altogether if no longer necessary). Ditto possibly some # noqa
s if there are any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could remove the import-outside-toplevel
disable and comment from pylintrc
while at it.
This doens't fix all top imports. I also see that legacy scene support is now going to kick our but, as it imports constants from integrations that now need their dependencies installed. |
I will close this for now. |
Actually that was just 1 import. Let's try to fix this. |
I couldn't reopen this, new one at #27293 |
Description:
Run script to move single line imports up. Then run isort on changed files to make the sorting correct.
Part of #27284
Hacked together with this script: