-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pylint #27279
Upgrade pylint #27279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Imports inside functions is indeed no longer necessary, so could be resolved (but would be a lot of work).
It would be great if we could resolve the imports since it would make an excellent guard. Hacktoberfest issue? |
I have created #27284 as a tracking issue. If you guys agree, I will mark it for |
That's fine. However, could we automate it ? Let me hack at it for 15m. |
26 minutes. Not bad: #27288 |
Description:
Upgrade pylint to 2.4.2 and astroid to 2.3.1, address raised issues.
https://pylint.readthedocs.io/en/latest/whatsnew/2.4.html
https://pylint.readthedocs.io/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-4-1
https://pylint.readthedocs.io/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-4-2
Bunch of false positive/bug workarounds needed, but some useful new issues caught too.
import-outside-toplevel
disabled altogether for now, but I assume it would be ok to change those as well nowadays?Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: