-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ZHA force polled entities. #22222
Fix ZHA force polled entities. #22222
Conversation
Ha, this is a nice PR# |
can merge when everything passes |
Go play powerball |
## Description: Fix "force_polled" ZHA entities. ## Checklist: - [x] The code change is tested and works locally. - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR. [ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard/__init__.py#L14 [ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard/__init__.py#L23
Not sure where to post this, but my ZHA devices were reporting better in 90.0 than in 90.1. can someone explain why that would have been? I'd like my devices to respond how they did in 90.0. |
@tbrock47 Can you describe exactly the behaviors you are seeing and with what devices? |
I'm running a raspberry pi with that nortek security and control stick that
everyone else uses.
I have about six sengled bulbs. In version 90.0 when zha would start
failing the zha device would start reporting unavailable. With 90.1 they
just report online even though they can't be reached.
I'm sorry I don't recall exactly what the log entry was when they start
stating that they can't be contacted anymore.
Reason being is I had an automation built that would restart home assistant
when all of my zha devices become unavailable which now doesn't work
because everything stays set as online.
I'm a git newbie so my apologies if there was a more appropriate way to
report my issues.
…On Sun, Mar 24, 2019, 7:30 PM Robbie Trencheny ***@***.***> wrote:
@tbrock47 <https://github.com/tbrock47> Can you describe exactly the
behaviors you are seeing and with what devices?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmG8cBw4xdUxk7DNZJD3AnvVY2KlVdHTks5vaCbNgaJpZM4cAD9M>
.
|
@tbrock47 This was the right place. @dmulcahey pulling you in on this, especially interesting since you have Sengled bulbs too and haven't experienced these issues... |
Some more details which would probably be helpful...
All the problem bulbs are Sengled E11-G13. This is the automation I spoke of that executes a restart when no ZHA devices report online anymore. But as I said, now that their state no longer changes from online, the automation never fires.
|
@robbiet480 we want issues reported in the issue tracker. Not in merged PRs. @tbrock47 Please open a new issue and copy the very good description already posted here. Make sure to fill out the issue template completely. And link to this PR. Thanks! Here's the link to our issue tracker: |
@MartinHjelmare you're right, thought this was the issue :( @tbrock47 Let us know when that new issue is opened, thanks! |
@tbrock47 Thank you for a good description of the problem. Let me know when you open the issue, but from the description the problem sounds very similar to zigpy/bellows#124 issue. We'll need |
Description:
Fix "force_polled" ZHA entities.
Checklist:
tox
. Your PR cannot be merged unless tests pass