Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Adafruit-DHT==1.3.3 #15707

Closed
wants to merge 1 commit into from
Closed

Conversation

googanhiem
Copy link

@googanhiem googanhiem commented Jul 27, 2018

Fixes install error with more up-to-date pypi repo

Description:

Related issue (if applicable): fixes #15333

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Fixes install error with more up-to-date pypi repo
@homeassistant
Copy link
Contributor

Hi @googanhiem,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Jul 27, 2018
@awarecan awarecan changed the title Update dht.py Upgrade Adafruit-DHT==1.3.3 Jul 27, 2018
Copy link
Contributor

@awarecan awarecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@googanhiem

Please read Pull Request template

New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@MartinHjelmare
Copy link
Member

Duplicate of #15706.

@nhorvath
Copy link
Contributor

you didn't update requirements_all.txt

@awarecan
Copy link
Contributor

I am fixing #15706, close this one.

@awarecan awarecan closed this Jul 27, 2018
@ghost ghost removed the in progress label Jul 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: dht small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.73 install fails DHT Adafruit_Python_DHT==1.3.2 (as requested by the sensor)
5 participants