-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Adafruit-DHT to 1.3.3 #15706
Conversation
The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3. See: adafruit/Adafruit_Python_DHT#99
Hi @superpuffin, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See checklist:
- New or updated dependencies have been added to
requirements_all.txt
by runningscript/gen_requirements_all.py
.
New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.
Adafruit_Python_DHT changed name to Adafruit-DHT, which still need pyx support breaking our CI, need to be comment out.
After this is merged, we need add the changes also to Hass.io |
@fabaff will you approve this? |
So is this fix included in 0.75? If not, is there any way to run dev on hassOS to have the fix included / to test it? Thanks in advance |
Not in 0.75, it missed train. hassOS/hass.io problem please ask in forum or discord, not under this PR. |
* Change to newer pip package The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3. See: adafruit/Adafruit_Python_DHT#99 * Update requirements_all.txt New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`. * Comment out Adafruit-DHT Adafruit_Python_DHT changed name to Adafruit-DHT, which still need pyx support breaking our CI, need to be comment out. * Update requirements_all.txt
Buongirno, I return these errors, how do I solve?
my config
|
The package Adafruit_Python_DHT==1.3.2 was broken and would not install, breaking DHT sensor support in Home assistant. It has since been fixed in Adafruit-DHT==1.3.3.
See: adafruit/Adafruit_Python_DHT#99
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: