Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reolink dispatcher ID for onvif fallback #131953

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

When TCP initialy works, the webhook for ONVIF push will not be subscribed and the webhook_id will be None.
The entties then subscibe to the dispatcher with a wrong ID.
This fixes that such that when the ONVIF push is later used as fallback, the dispatcher will have a correct and unique ID such that the signaling gets to the entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG added this to the 2024.12.0 milestone Nov 30, 2024
@starkillerOG starkillerOG changed the title Reolink fix onvif fallback Fix Reolink dispatcher ID for onvif fallback Nov 30, 2024
@bdraco
Copy link
Member

bdraco commented Nov 30, 2024

Would you please add a test to ensure this doesn't regress again in the future?

@starkillerOG
Copy link
Contributor Author

@bdraco I would not know how I could have caught this with a test.
There are tests in place for the dispatcher (the once I also update in this PR).
But they did not catch this because the webhook_id was "None" in both the test dispatch connect and during the testing.
The problem arose when later the webhook_id changed.

Since now the unique_ID is used it will never be None again and be constant and not change.

@starkillerOG starkillerOG merged commit db430be into home-assistant:dev Dec 2, 2024
34 checks passed
@starkillerOG starkillerOG deleted the reolink_fix_onvif branch December 2, 2024 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants