Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast translation string #131156

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix cast translation string #131156

merged 1 commit into from
Nov 21, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Nov 21, 2024

In the 'show_lovelace_view' action of the Cast integration there are two fields for specifying the Dashboard URL path and optionally the View URL path.

The description of the latter lacks "URL" so it's easy to misunderstand "View path" as it happened in the German translation that had turned this into "viewing a path".

Proposed change

Fix this by adding "URL" to the second description as well. So we get consistent explanations:

  • The URL path of the dashboard to show.
  • The URL path of the dashboard view to show.

Note that including "URL" also makes sense as the Dashboard editor in the frontend calls these just "URL".
This might warrant an additional PR for the frontend to use "URL path" there as well, as these are not complete URLs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

In the show_lovelace_view action of the Cast integration there are two fields for specifying the Dashboard URL path and optional the View URL path.

The description of the latter lacks "URL" so it's easy to misunderstand "View path" as it happened in the German translation that had turned this into "viewing a path".
@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (cast) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cast can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cast Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet changed the title Make descriptions of Dashboard path and View path consistent Fix cast translation string Nov 21, 2024
@joostlek joostlek added this to the 2024.11.3 milestone Nov 21, 2024
@joostlek joostlek merged commit 1e1759c into home-assistant:dev Nov 21, 2024
34 checks passed
frenck pushed a commit that referenced this pull request Nov 22, 2024
@frenck frenck mentioned this pull request Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast: Add "URL" to description and names of "View path" and "Dashboard path" for consistency
4 participants