Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast: Add "URL" to description and names of "View path" and "Dashboard path" for consistency #129618

Closed
NoRi2909 opened this issue Nov 1, 2024 · 1 comment · Fixed by #131156
Assignees
Labels
good first issue Issues that are suitable for first-time contributors. integration: cast translations

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Nov 1, 2024

The problem

In the description of "View path" the word "URL" is missing:

"dashboard_path": {
"name": "Dashboard path",
"description": "The URL path of the dashboard to show."
},
"view_path": {
"name": "View path",
"description": "The path of the dashboard view to show."

Should be

 "description": "The URL path of the dashboard view to show." 

as that field is just labelled "URL" in the dashboard editor UI:

image

Note:
I stumbled over this a bit harder as the German translators had turned "view path" into "viewing a path" which made things even worse. I fixed that in Lokalise yesterday.

What version of Home Assistant Core has the issue?

2024.11.0b1

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

https://rc.home-assistant.io/integrations/cast

@home-assistant
Copy link

home-assistant bot commented Nov 1, 2024

Hey there @emontnemery, mind taking a look at this issue as it has been labeled with an integration (cast) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cast can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign cast Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


cast documentation
cast source
(message by IssueLinks)

@joostlek joostlek added translations good first issue Issues that are suitable for first-time contributors. labels Nov 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issues that are suitable for first-time contributors. integration: cast translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants