-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update climate strings for consistent names and descriptions #130967
Conversation
Fix the current naming and description of the `set_temperature` action and its different data attributes. Currently the names are inconsistent with the defined attributes of a climate device and the decriptions don't add any information as they just repeat the names in a different word order.
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all requested changes have been processed. Resetting the review status back to: Requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NoRi2909 👍
../Frenck
Fix the current naming and description of the
set_temperature
action and its different data attributes.Currently the names are inconsistent with the defined attributes of a climate device and the descriptions don't add any information as they just repeat the names in a different word order.
In addition it adds "operation" to the preset mode explanations to make them consistent with all other mode actions.
Proposed change
Bring the descriptions of the
set_temperature
action and its data attributes to the usual level.Better align them with the online documentation.
Remove several inconsistencies.
Type of change
Additional information
set_temperature
action #130762Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: