Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climate: Improve descriptions of target temperatures in set_temperature action #130762

Closed
NoRi2909 opened this issue Nov 16, 2024 · 1 comment · Fixed by #130967
Closed

Climate: Improve descriptions of target temperatures in set_temperature action #130762

NoRi2909 opened this issue Nov 16, 2024 · 1 comment · Fixed by #130967

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Nov 16, 2024

The problem

Currently the descriptions of the set_temperature action and its different data attributes don't really explain anything but simply repeat the names in a different word order:

"set_temperature": {
"name": "Set target temperature",
"description": "Sets target temperature.",
"fields": {
"temperature": {
"name": "Temperature",
"description": "Target temperature."
},
"target_temp_high": {
"name": "Target temperature high",
"description": "High target temperature."
},
"target_temp_low": {
"name": "Target temperature low",
"description": "Low target temperature."

This should be fixed by following the explanations from the documentation:

New target temperature for climate device (commonly referred to as a setpoint).

The highest temperature that the climate device will allow. 

The lowest temperature that the climate device will allow.

And by using the labels defined in the entity componentsection of the file:

"target_temp_high": {
"name": "Upper target temperature"
},
"target_temp_low": {
"name": "Lower target temperature"
},
"target_temp_step": {
"name": "Target temperature step"
},
"temperature": {
"name": "Target temperature"

Combined this becomes:

Target temperature
The setpoint for the climate device.

Upper target temperature
The highest temperature that the climate device will allow.

Lower target temperature
The lowest temperature that the climate device will allow.

With these three strings I also know how to properly translate that into German. ;-)

What version of Home Assistant Core has the issue?

core-2024.11.2

Integration causing the issue

Climate

Link to integration documentation on our website

https://www.home-assistant.io/integrations/climate/

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign climate Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


climate documentation
climate source
(message by IssueLinks)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant