Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set ESPHome configuration url to addon if there is an existing configuration for the device #129356

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Only set ESPHome configuration url to addon if there is an existing configuration for the device #129356

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0909cf8
Only set ESPHome configuration url to addon if there is an existing c…
jesserockz Oct 28, 2024
4391353
Apply suggestions from code review
jesserockz Oct 30, 2024
492037e
Format
jesserockz Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/esphome/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,8 @@ def _async_setup_device_registry(
if device_info.webserver_port > 0:
configuration_url = f"http://{entry.data['host']}:{device_info.webserver_port}"
elif dashboard := async_get_dashboard(hass):
jesserockz marked this conversation as resolved.
Show resolved Hide resolved
configuration_url = f"homeassistant://hassio/ingress/{dashboard.addon_slug}"
if dashboard.data.get(device_info.name):
configuration_url = f"homeassistant://hassio/ingress/{dashboard.addon_slug}"
bdraco marked this conversation as resolved.
Show resolved Hide resolved
jesserockz marked this conversation as resolved.
Show resolved Hide resolved

manufacturer = "espressif"
if device_info.manufacturer:
Expand Down