-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only set ESPHome configuration url to addon if there is an existing configuration for the device #129356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration for the device
home-assistant
bot
added
bugfix
cla-signed
Hacktoberfest
integration: esphome
small-pr
PRs with less than 30 lines.
labels
Oct 28, 2024
Hey there @OttoWinter, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
kbx81
approved these changes
Oct 28, 2024
bdraco
approved these changes
Oct 28, 2024
bdraco
reviewed
Oct 28, 2024
bdraco
reviewed
Oct 28, 2024
bdraco
reviewed
Oct 28, 2024
Co-authored-by: J. Nick Koston <[email protected]>
bdraco
approved these changes
Nov 4, 2024
Would be nice to add a test in a followup PR for this case. |
bramkragten
pushed a commit
that referenced
this pull request
Nov 4, 2024
…onfiguration for the device (#129356) Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
Hacktoberfest
integration: esphome
Quality Scale: platinum
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
ESPHome devices do not need the configuration URL to point to the dashboard if there is no configuration present for the current device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: