Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fing integration #126058
base: dev
Are you sure you want to change the base?
Add Fing integration #126058
Changes from 19 commits
5b23ba2
5444759
70947f0
b05fabe
81ff32a
ee5e2fb
0a82943
d01a2f0
6810900
3f72f02
81d90d8
899d5f4
5f8b2e9
2a08e16
40a5223
ce8fd54
1fb1b76
214bdc4
0593355
22ef94d
60553ee
212f3f9
69788d8
6a4b841
c0a8c01
40d4d4d
12c9f1b
91649c3
5dd96bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only config flow is allowed to catch bare exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good to know. Are the exceptions handled by the Home Assistant core code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed other coordinators, and some of them follow the same pattern: raising an UpdateFailed exception when an update fails.
Did I wrote something wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh we should indeed raise
UpdateFailed
, but we should not catch bare exceptions. We want to be more specific on what we catch.Please double check the
DataUpdateCoordinator
class, because I believe it already catches issues fromhttpx
(I know it catchesaiohttp
exceptions, but I am not sure ifhttpx
also is catched). We should catch any extra exceptions then